refactor(interactive): Introduce call_proc as a new physical operator and implement it
#4288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ify-call-proc-op Committed-by: xiaolei.zl from Dev container
Committed-by: xiaolei.zl from Dev container
This comment was marked as resolved.
This comment was marked as resolved.
zhanglei1949
changed the title
call_proc as a new physical operator and implement it
Committed-by: xiaolei.zl from Dev container
Committed-by: xiaolei.zl from Dev container
zhanglei1949
commented
Oct 15, 2024
| const physical::ProcedureCall& opr, | ||
| const ReadTransaction& txn, | ||
| Context&& ctx) { | ||
| auto& query = opr.query(); |
There was a problem hiding this comment.
How should we fetch the procedure's handler here?
Committed-by: xiaolei.zl from Dev container
Committed-by: xiaolei.zl from Dev container
Committed-by: xiaolei.zl from Dev container
Committed-by: xiaolei.zl from Dev container
|
Please check the preview of the documentation changes at |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4288 +/- ##
=======================================
Coverage 36.96% 36.96%
=======================================
Files 126 126
Lines 13235 13235
=======================================
Hits 4892 4892
Misses 8343 8343 Continue to review full report in Codecov by Sentry.
|
luoxiaojian
approved these changes
Oct 22, 2024
liulx20
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently have too kinds graph queries. One is adhoc query, the other is
call_procquery. We provide two different route and APIs for these two kind of queries, but it is possible to mergecall_procquery into adhoc query, as an operator.In this PR, we Introduce a
CALL_PROCEDUREoperator intoPhysicalPlanproto. So, we could remove the/v1/graph/{id}/queryfrom compiler side. However, we still need the API in server side, for SDK to use.TODO
procedure_call.cc, including get app_base, and get session. Ideally, we shoud not only involve interfaces of ReadTransaction. -> Negativeprocedure_call.cc.User now could embed the
call_procin a cypher query, for examplewhere
k_neighborsis a builtin procedure.Fixes #4278